Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
Nico Huber has posted comments on this change. ( https://review.coreboot.org/23865 )
Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/#/c/23865/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23865/1//COMMIT_MSG@7 PS1, Line 7:
Sure: […]
Maybe prefix with `Makefile: `, line length should be <=55 chars, 65 maximum.
https://review.coreboot.org/#/c/23865/1/Makefile File Makefile:
https://review.coreboot.org/#/c/23865/1/Makefile@101 PS1, Line 101: enviroment enviro*n*ment
https://review.coreboot.org/#/c/23865/1/Makefile@102 PS1, Line 102: # uname returns MINGW32_NT-5.1 on XP, MINGW32_NT-6.1 on Windows 7 missing full-stop
https://review.coreboot.org/#/c/23865/1/Makefile@103 PS1, Line 103: # the regexp should support 64 bit variant of mingw if exists Please write a complete sentence, starting in upper-case, ending with a full-stop.
https://review.coreboot.org/#/c/23865/1/Makefile@104 PS1, Line 104: else echo no; no need for the `echo no`
https://review.coreboot.org/#/c/23865/1/Makefile@104 PS1, Line 104: ifeq ($(shell if [[ $$(uname) =~ ^MINGW[0-9]{0,2}_NT-[0-9]{1,2}.[0-9]{1,2}$$ ]]; then echo yes; else echo no; fi), yes)
Kind of. It is a regexp check inspired by this: […]
Can we assume that bash is always available in MinGW/MSYS? If so, we should redirect stderr at least (`2>/dev/null` maybe? please test with MinGW).
https://review.coreboot.org/#/c/23865/1/Makefile@104 PS1, Line 104: $$(uname) you could use "$(HOST_OS)" instead of $$(uname)
-
Nico Huber (Code Review)