7 comments:
Sure: […]
Maybe prefix with `Makefile: `, line length should be <=55 chars,
65 maximum.
Patch Set #1, Line 101: enviroment
enviro*n*ment
Patch Set #1, Line 102: # uname returns MINGW32_NT-5.1 on XP, MINGW32_NT-6.1 on Windows 7
missing full-stop
Patch Set #1, Line 103: # the regexp should support 64 bit variant of mingw if exists
Please write a complete sentence, starting in upper-case, ending
with a full-stop.
Patch Set #1, Line 104: else echo no;
no need for the `echo no`
Patch Set #1, Line 104: ifeq ($(shell if [[ $$(uname) =~ ^MINGW[0-9]{0,2}_NT-[0-9]{1,2}.[0-9]{1,2}$$ ]]; then echo yes; else echo no; fi), yes)
Kind of. It is a regexp check inspired by this: […]
Can we assume that bash is always available in MinGW/MSYS? If so,
we should redirect stderr at least (`2>/dev/null` maybe? please test
with MinGW).
Patch Set #1, Line 104: $$(uname)
you could use "$(HOST_OS)" instead of $$(uname)
To view, visit change 23865. To unsubscribe, or for help writing mail filters, visit settings.