Change in flashrom[staging]: spi25: Use common code for nbyte read/write and erase

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22019 )

Change subject: spi25: Use common code for nbyte read/write and erase
......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/22019/1/spi25.c
File spi25.c:

https://review.coreboot.org/#/c/22019/1/spi25.c@326
PS1, Line 326: spi_write_status
> spi_poll_status?

Yeah, that is what it does. Though, with all the FIXMEs fixed, it
should be more like check_write_status()... Don't have a strong
preference (but it should keep `write` in its name). spi_poll_wip()
maybe?

https://review.coreboot.org/#/c/22019/1/spi25.c@377
PS1, Line 377: JEDEC_WREN
> Hmmm, what do we do about chips that only use EWSR? I know this patch is on

I'm not an expert, but thought EWSR is actually only used before
status register updates.

https://review.coreboot.org/#/c/22019/1/spi25.c@383
PS1, Line 383:
> Check if out_len < 1?

Hmmm, no as it's also used for block erasers. I guess the function
name needs to reflect that better, or the signature needs to be
commented.