Nico Huber posted comments on this change.

View Change

Patch set 1:

(3 comments)

• File spi25.c:

  • Patch Set #1, Line 326: spi_write_status

    spi_poll_status?

    Yeah, that is what it does. Though, with all the FIXMEs fixed, it
    should be more like check_write_status()... Don't have a strong
    preference (but it should keep `write` in its name). spi_poll_wip()
    maybe?

  • Patch Set #1, Line 377: JEDEC_WREN

    Hmmm, what do we do about chips that only use EWSR? I know this patch is on

    I'm not an expert, but thought EWSR is actually only used before
    status register updates.

  • Patch Set #1, Line 383:

    Check if out_len < 1?

    Hmmm, no as it's also used for block erasers. I guess the function
    name needs to reflect that better, or the signature needs to be
    commented.

To view, visit change 22019. To unsubscribe, visit settings.