Nico Huber posted comments on this change.
Patch set 1:
Patch Set #1, Line 326:
Yeah, that is what it does. Though, with all the FIXMEs fixed, it
should be more like check_write_status()... Don't have a strong
preference (but it should keep `write` in its name). spi_poll_wip()
Patch Set #1, Line 377:
Hmmm, what do we do about chips that only use EWSR? I know this patch is on
I'm not an expert, but thought EWSR is actually only used before
status register updates.
Check if out_len < 1?
Hmmm, no as it's also used for block erasers. I guess the function
name needs to reflect that better, or the signature needs to be
To view, visit change 22019. To unsubscribe, visit settings.