Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57973 )
Change subject: raiden_debug_spi: Use spi data in configure_protocol
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/57973/comment/c1b0f6ad_acaebc5f
PS1, Line 1599: spi_config->data = data; /* data is needed to configure protocol below */
Maybe worth to mention in the commit message, that this is not
needed anymore, because register_spi_master() will do it later.
https://review.coreboot.org/c/flashrom/+/57973/comment/6ecf7ed4_8ca5cdcf
PS1, Line 1327: struct raiden_debug_spi_data *ctx_data =
: (struct raiden_debug_spi_data *)data;
No cast necessary, it already has that type. Or...
alternatively, just name the parameter `ctx_data`?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57973
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5df0609efcd1fdb274b8cc84536253d5dbae5270
Gerrit-Change-Number: 57973
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 30 Sep 2021 16:11:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment