Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.

Patch set 1:Code-Review +1

View Change

2 comments:

• File raiden_debug_spi.c:

  • Patch Set #1, Line 1599: spi_config->data = data; /* data is needed to configure protocol below */

    Maybe worth to mention in the commit message, that this is not
    needed anymore, because register_spi_master() will do it later.

  • Patch Set #1, Line 1327:

    struct raiden_debug_spi_data *ctx_data =
    		(struct raiden_debug_spi_data *)data;
    

    No cast necessary, it already has that type. Or...

    alternatively, just name the parameter `ctx_data`?

To view, visit change 57973. To unsubscribe, or for help writing mail filters, visit settings.