Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56324 )
Change subject: tests: Add layout tests for overlapping regions
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File tests/layout.c:
https://review.coreboot.org/c/flashrom/+/56324/comment/009327ee_ce662587
PS1, Line 21: int flashrom_layout_new(struct flashrom_layout **);
: int flashrom_layout_add_region(struct flashrom_layout *, size_t start, size_t end, const char *name);
: int flashrom_layout_include_region(struct flashrom_layout *, const char *name);
: void flashrom_layout_release(struct flashrom_layout *);
This looks a bit awkward, but... The functions are not static in layout.c. […]
what about including `libflashrom.h` will that not work?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56324
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7aa8dc0c9bc5a22fe5deea757eea1a151b969cea
Gerrit-Change-Number: 56324
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nikolai Artemiev
nartemiev@google.com
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 15 Jul 2021 00:29:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment