Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.

Patch set 1:Code-Review +1

View Change

1 comment:

• File tests/layout.c:

  • Patch Set #1, Line 21:

    int flashrom_layout_new(struct flashrom_layout **);
    int flashrom_layout_add_region(struct flashrom_layout *, size_t start, size_t end, const char *name);
    int flashrom_layout_include_region(struct flashrom_layout *, const char *name);
    void flashrom_layout_release(struct flashrom_layout *);
    

    This looks a bit awkward, but... The functions are not static in layout.c. […]

    what about including `libflashrom.h` will that not work?

To view, visit change 56324. To unsubscribe, or for help writing mail filters, visit settings.