Change in flashrom[master]: [RFC] writeprotect, cli_classic: create writeprotect foundation

[Angel Pons (Code Review)]

Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58474 )

Change subject: [RFC] writeprotect, cli_classic: create writeprotect foundation
......................................................................

Patch Set 5:

(2 comments)

File cli_classic.c:

https://review.coreboot.org/c/flashrom/+/58474/comment/ea24904a_2f71d408 
PS5, Line 778: set_wp_disable should be done before setting the range
> Is there way to check this pre-requisite in set_wp_range?

Or even have `set_wp_range` disable WP beforehand (bail out if it fails) and restore the WP state afterwards.

File writeprotect.c:

PS3:
> Yes I agree. […]

I don't understand what the point of `struct wp` is. Currently, write protection support is only considered for SPI, so I don't see the need to have pointer indirection.

Also, if `struct wp` is to be removed, why not get rid of it in first place? What benefit does keeping it provide?