Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev.

View Change

2 comments:

• File cli_classic.c:

  • Patch Set #5, Line 778: set_wp_disable should be done before setting the range

    Is there way to check this pre-requisite in set_wp_range?

    Or even have `set_wp_range` disable WP beforehand (bail out if it fails) and restore the WP state afterwards.

• File writeprotect.c:

  • Patch Set #3:

    Yes I agree. […]

    I don't understand what the point of `struct wp` is. Currently, write protection support is only considered for SPI, so I don't see the need to have pointer indirection.

    Also, if `struct wp` is to be removed, why not get rid of it in first place? What benefit does keeping it provide?

To view, visit change 58474. To unsubscribe, or for help writing mail filters, visit settings.