Attention is currently required from: Nico Huber, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61582 )
Change subject: cli_classic: Use flashrom_init() from API ......................................................................
Patch Set 4:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/61582/comment/fe70adc4_a5bc4763 PS4, Line 353: /* FIXME: Delay calibration should happen in programmer code. */
Would be much less confusing if moved into flashrom_init(). But I'm […]
It will be good to turn these distractions of rotting FIXME's into actual bugs in the bug tracker and prioritse them so they don't hang around for years and popping up in patch review in this way.
Probably a solution to the problem though is for programmers to have flags that indicate they need these sorts of special treatments and dispatch into a side-helpers to service them.
-
Edward O'Callaghan (Code Review)