Attention is currently required from: Nico Huber, Angel Pons.
View Change
1 comment:
File cli_classic.c:
Patch Set #4, Line 353: /* FIXME: Delay calibration should happen in programmer code. */
Would be much less confusing if moved into flashrom_init(). But I'm […]
It will be good to turn these distractions of rotting FIXME's into actual bugs in the bug tracker and prioritse them so they don't hang around for years and popping up in patch review in this way.
Probably a solution to the problem though is for programmers to have flags that indicate they need these sorts of special treatments and dispatch into a side-helpers to service them.
To view, visit change 61582. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I07faeed876f678c35355621a080c7852eed16824
Gerrit-Change-Number: 61582
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 12:18:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment