Change in flashrom[master]: pcidev: Construct a API to handle phantom pci controllers - flashrom-gerrit

11 May 2022


      Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62951 )
Change subject: pcidev: Construct a API to handle phantom pci controllers
......................................................................
Patch Set 3:
(1 comment)
File include/programmer.h:
https://review.coreboot.org/c/flashrom/+/62951/comment/ee10e055_97bcdaf1 
PS3, Line 133: pcidev_phantom_spidev
It would be great to have a name of the function with a verb, to explain what it is doing (get_pcidev_phantom_spidev maybe?). 
At the moment there are 3 nouns in a row. Maybe it's just me, but I was looking at the call in chipset_enable and could not understand what this function is doing.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic75573a14c9997a2d0347cd683ffc0c78d1b3a4f
Gerrit-Change-Number: 62951
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Subrata Banik subratabanik@google.com
Gerrit-CC: Thomas Heijligen src@posteo.de
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Wed, 11 May 2022 05:11:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment