Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan.

View Change

1 comment:

• File include/programmer.h:

  • Patch Set #3, Line 133: pcidev_phantom_spidev

    It would be great to have a name of the function with a verb, to explain what it is doing (get_pcidev_phantom_spidev maybe?).
    At the moment there are 3 nouns in a row. Maybe it's just me, but I was looking at the call in chipset_enable and could not understand what this function is doing.

To view, visit change 62951. To unsubscribe, or for help writing mail filters, visit settings.