Attention is currently required from: ChrisEric1 CECL, Thomas Heijligen.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB Controller flashing ......................................................................
Patch Set 20: Code-Review+1
(14 comments)
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/ecdcf810_0d5e0527 PS18, Line 70: unsigned int i, j;
just scope iterators to loops.
delete
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/5aa6ae39_d2968a36 PS20, Line 24: #include "programmer.h" : #include "spi.h" : #include "flash.h" : #include "platform/pci.h" : #include <stdlib.h> ``` #include <stdlib.h>
include ".." ``` alphabetical ordering.
https://review.coreboot.org/c/flashrom/+/72057/comment/dd452a66_ff28f1bd PS20, Line 70: uint32_t outdata; : uint32_t indata; delete
https://review.coreboot.org/c/flashrom/+/72057/comment/be6fe83f_c44f08c9 PS20, Line 75: for (j = 0; j < writecnt; j += 4) { `for (unsigned int i = 0; i < writecnt; i += 4) {`
https://review.coreboot.org/c/flashrom/+/72057/comment/8f215d59_2cd4a4b4 PS20, Line 76: j i
https://review.coreboot.org/c/flashrom/+/72057/comment/16850d1a_0ec3e161 PS20, Line 76: u const
https://review.coreboot.org/c/flashrom/+/72057/comment/4105d6f8_2498ef9b PS20, Line 77: o you can just do: `uint32_t data = 0;`
https://review.coreboot.org/c/flashrom/+/72057/comment/8bd7c0f8_548b221c PS20, Line 78: for (i = 0; i < curwritecnt; i++) { `for (unsigned int j = 0; j < curwritecnt; j++) {`
https://review.coreboot.org/c/flashrom/+/72057/comment/4add081c_8cfce578 PS20, Line 89: for (j = 0; j < readcnt; j += 4) { `for (unsigned int i = 0; i < readcnt; i += 4) {`
https://review.coreboot.org/c/flashrom/+/72057/comment/86bc9f9b_fcefb4f5 PS20, Line 90: j i
https://review.coreboot.org/c/flashrom/+/72057/comment/30e415e1_236797cd PS20, Line 90: u const
https://review.coreboot.org/c/flashrom/+/72057/comment/0f1986d2_caed8785 PS20, Line 92: indata `uint32_t data =`
https://review.coreboot.org/c/flashrom/+/72057/comment/927efce4_e21418ab PS20, Line 93: for (i = 0; i < curreadcnt; i++) { `for (unsigned int j = 0; j < curreadcnt; j++) {`
https://review.coreboot.org/c/flashrom/+/72057/comment/87d8f565_e1c9020e PS20, Line 94: i j
-
Edward O'Callaghan (Code Review)