Attention is currently required from: ChrisEric1 CECL, Thomas Heijligen.

Patch set 20:Code-Review +1

View Change

14 comments:

• File vl805.c:

  • Patch Set #18, Line 70: unsigned int i, j;

    just scope iterators to loops.

    delete

• File vl805.c:

  • Patch Set #20, Line 24:

    #include "programmer.h"
    #include "spi.h"
    #include "flash.h"
    #include "platform/pci.h"
    #include <stdlib.h>
    

    ```
    #include <stdlib.h>

    include ".."
    ```
    alphabetical ordering.

  • Patch Set #20, Line 70:

    	uint32_t outdata;
    	uint32_t indata;
    

    delete

  • Patch Set #20, Line 75: for (j = 0; j < writecnt; j += 4) {

    `for (unsigned int i = 0; i < writecnt; i += 4) {`

  • Patch Set #20, Line 76: j

    i

  • Patch Set #20, Line 76: u

    const

  • Patch Set #20, Line 77: o

    you can just do:
    `uint32_t data = 0;`

  • Patch Set #20, Line 78: for (i = 0; i < curwritecnt; i++) {

    `for (unsigned int j = 0; j < curwritecnt; j++) {`

  • Patch Set #20, Line 89: for (j = 0; j < readcnt; j += 4) {

    `for (unsigned int i = 0; i < readcnt; i += 4) {`

  • Patch Set #20, Line 90: j

    i

  • Patch Set #20, Line 90: u

    const

  • Patch Set #20, Line 92: indata

    `uint32_t data =`

  • Patch Set #20, Line 93: for (i = 0; i < curreadcnt; i++) {

    `for (unsigned int j = 0; j < curreadcnt; j++) {`

  • Patch Set #20, Line 94: i

    j

To view, visit change 72057. To unsubscribe, or for help writing mail filters, visit settings.