Attention is currently required from: Nico Huber, Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62733 )
Change subject: writeprotect_ranges.c: Use 1UL if left shifting more than 32bits ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62733/comment/54d8f9a0_92fec78a PS2, Line 12: Still the bug is not fixed :(
I wonder if casting the `1` to `size_t` would work: […]
I don't think it would work as the max value that bp_max can take is 15 since the array bits->bp is of length MAX_BP_BITS which is 4. The error arises when bp_max takes values lower than 2. Then bp_max-2 becomes very large due to underflow error since size_t is unsigned type.
Any suggestions to solve this error?