Attention is currently required from: Nico Huber, Angel Pons.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 12: Still the bug is not fixed :(
I wonder if casting the `1` to `size_t` would work: […]
I don't think it would work as the max value that bp_max can take is 15 since the array bits->bp is of length MAX_BP_BITS which is 4. The error arises when bp_max takes values lower than 2. Then bp_max-2 becomes very large due to underflow error since size_t is unsigned type.
Any suggestions to solve this error?
To view, visit change 62733. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad
Gerrit-Change-Number: 62733
Gerrit-PatchSet: 3
Gerrit-Owner: Light <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 16:52:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment