Change in flashrom[master]: [v4, 5/6] Add the hidden-from-probing chips category and make KB9012 h...

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/23262 )

Change subject: [v4,5/6] Add the hidden-from-probing chips category and make KB9012 hidden
......................................................................


Patch Set 1:
> (1 comment)
>
> This should be done before adding the EDI driver.
>
> AFAIR, Paul had something more flexible in mind: Instead of the
> `hidden` flag a grouping of the chips. Basically the same what you
> did but instead of 0/1 values a default of JEDEC and alternatively
> EDI and whatever might come in the future. How about that?

I agree that grouping is a better idea. To be honest I'm not familiar with flashrom codebase, and at this moment it was a much simpler solution to just add this ".hidden" flag, partially because I didn't understand what would be the proper good way of introducing the groups... Are there any other problematic chips supported by flashrom like KB9012, probing for which could cause problems for other chips? If not, maybe it's still possible to use that ".hidden" flag as the quick initial solution (just to avoid KB9012 probing when its not needed) and upgrade it to the groups later, when other "hidden chips" arrive?


-- 
To view, visit https://review.coreboot.org/23262
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89a53ccaef2791a2ac32904d7ab813da7478a6f0
Gerrit-Change-Number: 23262
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <[e-mail]>
Gerrit-Reviewer: Mike Banon <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Paul Kocialkowski <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Tue, 30 Jan 2018 23:35:19 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No