Attention is currently required from: Anastasia Klimchuk, Dmitry Zhadinets.
Peter Marheine has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email )
Change subject: libflashrom: Update the API for Logger Callback ......................................................................
Patch Set 6:
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86875/comment/5571bfcd_cec26dd1?usp... : PS4, Line 59: /* Dynamic messages and double formatting may not be ideal, : as they are slow. It would be better to limit the message : size to a fixed value (e.g., char message[1024] = {0};). */
This is a question to a reviewer. […]
I would go shorter to perhaps 128 or 256 bytes, but have a fallback to dynamic allocation in case a message is longer than that. I wouldn't expect messages to ever be longer than 256 bytes, but it would be bad to silently drop or truncate messages because they were long.