Attention is currently required from: Anastasia Klimchuk, Dmitry Zhadinets.

View Change

1 comment:

• File libflashrom.c:

  • Patch Set #4, Line 59:

    	/* Dynamic messages and double formatting may not be ideal,
    	as they are slow. It would be better to limit the message
    	size to a fixed value (e.g., char message[1024] = {0};). */
    

    This is a question to a reviewer. […]

    I would go shorter to perhaps 128 or 256 bytes, but have a fallback to dynamic allocation in case a message is longer than that. I wouldn't expect messages to ever be longer than 256 bytes, but it would be bad to silently drop or truncate messages because they were long.

To view, visit change 86875. To unsubscribe, or for help writing mail filters, visit settings.