David Hendricks has posted comments on this change. ( https://review.coreboot.org/29306 )
Change subject: flashchips: Add IS25LP256 and IS25WP256 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/29306/1/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/29306/1/flashchips.c@7399 PS1, Line 7399: .block_erase = spi_block_erase_20,
Also aliased as d7. I wouldn't mind if you don't want to add it. […]
I tried adding d7, but ran into the NUM_ERASEFUNCTIONS limit. So I went with a comment instead - No need to change NUM_ERASEFUNCTIONS to accommodate a redundant instruction.