View Change
1 comment:
File flashchips.c:
Patch Set #1, Line 7399: .block_erase = spi_block_erase_20,
Also aliased as d7. I wouldn't mind if you don't want to add it. […]
I tried adding d7, but ran into the NUM_ERASEFUNCTIONS limit. So I went with a comment instead - No need to change NUM_ERASEFUNCTIONS to accommodate a redundant instruction.
To view, visit change 29306. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf7a224abcde5f7935d9ef88309f78207de60a7a
Gerrit-Change-Number: 29306
Gerrit-PatchSet: 4
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 23:08:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No