Attention is currently required from: Malcolm Boyes, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82259?usp=email )
Change subject: flashchips: Add support for Boya B25Q64AS ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1: Malcolm thank you for the patch! I have just one comment.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/82259/comment/a1d1cbe6_f96086f7 : PS1, Line 3640: SPI_DISABLE_BLOCKPROTECT_AT25FS040 I think SPI_DISABLE_BLOCKPROTECT_BP4_SRWD is more correct in this case which is
A common block protection disable that tries to unset the status register bits masked by 0x7C (BP0-4) and protected/locked by bit #7.
(Even if it might internally comes down to the same thing)
As I understand you were not testing write protection anyway, right?
-
Anastasia Klimchuk (Code Review)