Attention is currently required from: Malcolm Boyes, Nikolai Artemiev, Stefan Reinauer.

Patch set 1:Code-Review +1

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    Malcolm thank you for the patch! I have just one comment.

• File flashchips.c:

  • Patch Set #1, Line 3640: SPI_DISABLE_BLOCKPROTECT_AT25FS040

    I think SPI_DISABLE_BLOCKPROTECT_BP4_SRWD is more correct in this case
    which is
    > A common block protection disable that tries to unset the status register bits masked by 0x7C (BP0-4) and protected/locked by bit #7.

    (Even if it might internally comes down to the same thing)

    As I understand you were not testing write protection anyway, right?

To view, visit change 82259. To unsubscribe, or for help writing mail filters, visit settings.