Attention is currently required from: Edward O'Callaghan, Daniel Campello, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59291 )
Change subject: flashrom: Convert do_read() into a libflashrom user ......................................................................
Patch Set 4:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/59291/comment/5108cb42_bb9bca79 PS4, Line 2173: msg_cinfo("FAILED.\n"); This message is now left orphaned. Before, there was a message `msg_cinfo("Reading flash... ")` in the beginning of read_flash_to_file, and this one goes together with it. So if memory allocation does fail, the output was
Reading flash... Memory allocation failed! FAILED
Now `msg_cinfo("Reading flash... ")` happens in flashrom_image_read, but flashrom_image_read is called below. So if memory allocation does fail, the output will be
Memory allocation failed! FAILED
Maybe this orphaned FAILED can be removed? Do we consider memory allocation as a part of Reading flash or is it a pre-process step?
-
Anastasia Klimchuk (Code Review)