Attention is currently required from: Edward O'Callaghan, Daniel Campello, Angel Pons.

View Change

1 comment:

• File flashrom.c:

  • Patch Set #4, Line 2173: msg_cinfo("FAILED.\n");

    This message is now left orphaned.
    Before, there was a message `msg_cinfo("Reading flash... ")` in the beginning of read_flash_to_file, and this one goes together with it. So if memory allocation does fail, the output was

     Reading flash... 
     Memory allocation failed!
     FAILED

    Now `msg_cinfo("Reading flash... ")` happens in flashrom_image_read, but flashrom_image_read is called below. So if memory allocation does fail, the output will be

     Memory allocation failed!
     FAILED

    Maybe this orphaned FAILED can be removed? Do we consider memory allocation as a part of Reading flash or is it a pre-process step?

To view, visit change 59291. To unsubscribe, or for help writing mail filters, visit settings.