Attention is currently required from: Nico Huber, Edward O'Callaghan.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67004 )
Change subject: Use chipsize_t (uint32_t) for all range types ......................................................................
Patch Set 3:
(2 comments)
This change is ready for review.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/67004/comment/08067e28_39fd805d PS3, Line 852: const chipsize_t region_start = entry->start; I removed chipoff_t during this migration, as I did not understand the use case for having two types. I think they would never be different sizes. Maybe it was for documentation?
File util/flashrom_tester/flashrom/src/flashromlib.rs:
https://review.coreboot.org/c/flashrom/+/67004/comment/220653b8_a71c532c PS3, Line 124: let libflashrom::Range { start, end } = layout.get_region_range(region)?; having the rust API return u32 makes this code much more ugly. But it does mean pushing error handling to the user which allows them to make the appropriate choice.