Attention is currently required from: Nico Huber, Edward O'Callaghan.
2 comments:
File flashrom.c:
Patch Set #3, Line 852: const chipsize_t region_start = entry->start;
I removed chipoff_t during this migration, as I did not understand the use case for having two types. I think they would never be different sizes. Maybe it was for documentation?
File util/flashrom_tester/flashrom/src/flashromlib.rs:
Patch Set #3, Line 124: let libflashrom::Range { start, end } = layout.get_region_range(region)?;
having the rust API return u32 makes this code much more ugly. But it does mean pushing error handling to the user which allows them to make the appropriate choice.
To view, visit change 67004. To unsubscribe, or for help writing mail filters, visit settings.