Paul Kocialkowski has posted comments on this change. ( https://review.coreboot.org/23260 )
Change subject: edi: Add dummy read to ensure proper detection of ENE chips ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/23260/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23260/3//COMMIT_MSG@16 PS3, Line 16: Original patch has been created by Paul Kocialkowski, the previous version: Please remove this block now that author is fixed.
https://review.coreboot.org/#/c/23260/3/edi.c File edi.c:
https://review.coreboot.org/#/c/23260/3/edi.c@166 PS3, Line 166: static void edi_wakeup(struct flashctx *flash)
I've renamed it into edi_draw_attention and also tried to improve the description of this method, ho […]
I agree with Nico that inlining the function is preferable than coming up with names that aren't exactly obvious. The comment block is there to inform about what's going on anyway.
-
Paul Kocialkowski (Code Review)