View Change

2 comments:

• Commit Message:

  • Patch Set #3, Line 16: Original patch has been created by Paul Kocialkowski, the previous version:

    Please remove this block now that author is fixed.

• File edi.c:

  • Patch Set #3, Line 166: static void edi_wakeup(struct flashctx *flash)

    I've renamed it into edi_draw_attention and also tried to improve the description of this method, ho […]

    I agree with Nico that inlining the function is preferable than coming up with names that aren't exactly obvious. The comment block is there to inform about what's going on anyway.

To view, visit change 23260. To unsubscribe, or for help writing mail filters, visit settings.