Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 )
Change subject: [WIP] meson: rework the programmer selection ......................................................................
Patch Set 2:
(4 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/63724/comment/512ff217_b915376b PS2, Line 98: # 'deps' : list[dep], # fallback: [] Could each dep list additional files that it requires? It looks like every programmer that depends on libpci also needs pcidev.c, so it might be simpler to have the libpci dep specify that pcidev.c be built.
https://review.coreboot.org/c/flashrom/+/63724/comment/e11d4653_fab49dcc PS2, Line 418: p_x.get('deps',[]) deps is already defaulted to [] above, so this doesn't need to specify a fallback.
https://review.coreboot.org/c/flashrom/+/63724/comment/35091270_ac6ab336 PS2, Line 427: elif selected and available Seems clearer to nest these, since it isn't immediately obvious that this is the same condition as above but minus `deps_found`
if selected and available if deps_found active = true else error(...)
`selected_all and available` below could do the same.
https://review.coreboot.org/c/flashrom/+/63724/comment/68edf339_ebacc37f PS2, Line 464: if host_machine.system() in systems_serial_support Could we avoid building this if no programmer needs serial? Might need a bit of rework to express it as a kind of dependency.
-
Peter Marheine (Code Review)