Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.

View Change

4 comments:

• File meson.build:

  • Patch Set #2, Line 98: # 'deps' : list[dep], # fallback: []

    Could each dep list additional files that it requires? It looks like every programmer that depends on libpci also needs pcidev.c, so it might be simpler to have the libpci dep specify that pcidev.c be built.

  • Patch Set #2, Line 418: p_x.get('deps',[])

    deps is already defaulted to [] above, so this doesn't need to specify a fallback.

  • Patch Set #2, Line 427: elif selected and available

    Seems clearer to nest these, since it isn't immediately obvious that this is the same condition as above but minus `deps_found`

        if selected and available
            if deps_found
                active = true
            else
                 error(...)

    `selected_all and available` below could do the same.

  • Patch Set #2, Line 464: if host_machine.system() in systems_serial_support

    Could we avoid building this if no programmer needs serial? Might need a bit of rework to express it as a kind of dependency.

To view, visit change 63724. To unsubscribe, or for help writing mail filters, visit settings.