Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/45896 )
Change subject: realtek_mst_i2c_spi.c: Remove reset from init fn ......................................................................
realtek_mst_i2c_spi.c: Remove reset from init fn
Remove MCU reset on init as this was only introduced when MCU fw requirements for correct flashing were unknown however it turns out no MCU fw is required to flash and so no MCU reset should occur upon initialization.
Change-Id: Ia03f94effc4b720964638c032bbde5acfb13960d Signed-off-by: Edward O'Callaghan quasisec@google.com --- M realtek_mst_i2c_spi.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/45896/1
diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index 6158524..7867528 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -450,11 +450,6 @@ if (fd < 0) return fd;
- /* Ensure we are in a known state before entering ISP mode */ - ret |= realtek_mst_i2c_spi_reset_mpu(fd); - if (ret) - return ret; - ret |= realtek_mst_i2c_spi_enter_isp_mode(fd); if (ret) return ret;
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45896 )
Change subject: realtek_mst_i2c_spi.c: Remove reset from init fn ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45896 )
Change subject: realtek_mst_i2c_spi.c: Remove reset from init fn ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/45896 )
Change subject: realtek_mst_i2c_spi.c: Remove reset from init fn ......................................................................
realtek_mst_i2c_spi.c: Remove reset from init fn
Remove MCU reset on init as this was only introduced when MCU fw requirements for correct flashing were unknown however it turns out no MCU fw is required to flash and so no MCU reset should occur upon initialization.
Change-Id: Ia03f94effc4b720964638c032bbde5acfb13960d Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/45896 Reviewed-by: Sam McNally sammc@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M realtek_mst_i2c_spi.c 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Sam McNally: Looks good to me, approved
diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index 6158524..7867528 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -450,11 +450,6 @@ if (fd < 0) return fd;
- /* Ensure we are in a known state before entering ISP mode */ - ret |= realtek_mst_i2c_spi_reset_mpu(fd); - if (ret) - return ret; - ret |= realtek_mst_i2c_spi_enter_isp_mode(fd); if (ret) return ret;
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)
-
Sam McNally (Code Review)