[M] Change in flashrom[master]: tree/: Move programmer_delay() out of programmer state machine
Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Alexander Goncharov.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67393 )
Change subject: tree/: Move programmer_delay() out of programmer state machine ......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67393/comment/38dabfb9_2ddee046 PS4, Line 13:
Did the above answer the outstanding questions, is this resolved? This comment appears to have gone […]
Sorry for the late reply, couldn't sleep properly for more than a week... 😞 What you said makes sense, we'll need to read it again to make sure we understand it correctly (lack of sleep makes it hard).
Let's try to revisualize this. Re-checking the delay functions, looks like they rely on global variables that are also used by other programmer functions. If the long-term goal is to remove the global state, in which struct should these currently-global variables go?
-
Angel Pons (Code Review)