Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Alexander Goncharov.
View Change
1 comment:
Commit Message:
Patch Set #4, Line 13:
Did the above answer the outstanding questions, is this resolved? This comment appears to have gone […]
Sorry for the late reply, couldn't sleep properly for more than a week... 😞 What you said makes sense, we'll need to read it again to make sure we understand it correctly (lack of sleep makes it hard).
Let's try to revisualize this. Re-checking the delay functions, looks like they rely on global variables that are also used by other programmer functions. If the long-term goal is to remove the global state, in which struct should these currently-global variables go?
To view, visit change 67393. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id059abb58b31a066a408009073912da2b224d40c
Gerrit-Change-Number: 67393
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Wed, 02 Nov 2022 13:28:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment