Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev, Anastasia Klimchuk.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59074 )
Change subject: [RFC][WPTST] dummyflasher: enforce write protection for W25Q128FV
......................................................................
Patch Set 13:
(3 comments)
Patchset:
PS12:
If this patch completes wp emulation in dummyflasher, can it be tested from command line? I mean doi […]
Done
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/59074/comment/3ef96841_8ee69399
PS10, Line 264: /* XXX: should data->erase_to_zero be taken into account here? */
+1, preserving the current behavior with a FIXME comment is the best option IMO.
Done
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/59074/comment/fd69b4c6_2cb376df
PS12, Line 236: if (start >= data->wp_start && start < data->wp_end)
: return true;
:
: const uint32_t last = start + len - 1;
: return (last >= data->wp_start && last < data->wp_end);
These two tests can be combined as: […]
Thanks, done.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59074
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9fd1417f941186391bd213bd355530143c8f04a0
Gerrit-Change-Number: 59074
Gerrit-PatchSet: 13
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 06 Dec 2021 18:30:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment