Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev, Anastasia Klimchuk.

View Change

3 comments:

• Patchset:

  • Patch Set #12:

    If this patch completes wp emulation in dummyflasher, can it be tested from command line? I mean doi […]

    Done

• File dummyflasher.c:

  • Patch Set #10, Line 264: /* XXX: should data->erase_to_zero be taken into account here? */

    +1, preserving the current behavior with a FIXME comment is the best option IMO.

    Done

• File dummyflasher.c:

  • Patch Set #12, Line 236:

    	if (start >= data->wp_start && start < data->wp_end)
    		return true;
    
    	const uint32_t last = start + len - 1;
    	return (last >= data->wp_start && last < data->wp_end);
    

    These two tests can be combined as: […]

    Thanks, done.

To view, visit change 59074. To unsubscribe, or for help writing mail filters, visit settings.