Attention is currently required from: Antonio Vázquez Blanco.
Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85072?usp=email )
Change subject: Rename cli_classic.h to a more adequate cli_getop.h ......................................................................
Patch Set 2:
(2 comments)
File cli_getopt.c:
https://review.coreboot.org/c/flashrom/+/85072/comment/19c1e84f_e07deba2?usp... : PS1, Line 28: #include "cli_getopt.h"
Sorry, this is even subconscious for me. I do this because cli_getopt. […]
Thank you for explanation! This is useful for me. Agree to keep cli_getop.h line as you did. I mark this one resolved, I added one last comment below.
File cli_getopt.c:
https://review.coreboot.org/c/flashrom/+/85072/comment/9cd78fad_566b69c7?usp... : PS2, Line 35: #include <flash.h> Let's keep this line as it was
#include "flash.h"
Since this include is not related to the goal of the patch, let's not change this line.