Attention is currently required from: Antonio Vázquez Blanco.
View Change
2 comments:
File cli_getopt.c:
Patch Set #1, Line 28: #include "cli_getopt.h"
Sorry, this is even subconscious for me. I do this because cli_getopt. […]
Thank you for explanation! This is useful for me.
Agree to keep cli_getop.h line as you did.
I mark this one resolved, I added one last comment below.
File cli_getopt.c:
Patch Set #2, Line 35: #include <flash.h>
Let's keep this line as it was
#include "flash.h"
Since this include is not related to the goal of the patch, let's not change this line.
To view, visit change 85072. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Iaceeabedc26e93147d8122376d88e730aad1e355
Gerrit-Change-Number: 85072
Gerrit-PatchSet: 2
Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco@gmail.com>
Gerrit-Comment-Date: Mon, 11 Nov 2024 10:24:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Antonio Vázquez Blanco <antoniovazquezblanco@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>