Attention is currently required from: Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58737 )
Change subject: ichspi: Extract initialisation of swseq and hwseq into a function ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1: Tested probing and reading on Panther Point (7 series PCH).
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/58737/comment/21046c6b_8fff1245 PS1, Line 1786: size_t *num_freg, size_t *num_pr, size_t *reg_pr0, Technically these are not about sw/hw sequencing. Maybe just rename the function? Something like init_chipset_properties?
https://review.coreboot.org/c/flashrom/+/58737/comment/bb2af903_218c2d9d PS1, Line 1787: enum ich_chipset ich_gen) looks like one space is missing, or is Gerrit fooling me?