Attention is currently required from: Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
Patch set 1:Code-Review +1
View Change
3 comments:
Patchset:
File ichspi.c:
Patch Set #1, Line 1786: size_t *num_freg, size_t *num_pr, size_t *reg_pr0,
Technically these are not about sw/hw sequencing. Maybe just rename the
function? Something like init_chipset_properties?
Patch Set #1, Line 1787: enum ich_chipset ich_gen)
looks like one space is missing, or is Gerrit fooling me?
To view, visit change 58737. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7d62b1b380e497b82dcae1284d752204cc541bd3
Gerrit-Change-Number: 58737
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Wed, 15 Dec 2021 13:29:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment