Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62898 )
Change subject: hwaccess: replace macros by C code ......................................................................
Patch Set 8:
(6 comments)
File hwaccess.h:
https://review.coreboot.org/c/flashrom/+/62898/comment/7e1a19ab_bd1507f9 PS8, Line 77: uint##bits##_t name##bits (const uint##bits##_t value) { return swap##bits (value); } Exceeding 80 characters for better readability.
File hwaccess.h:
https://review.coreboot.org/c/flashrom/+/62898/comment/25588051_a4f2e8ce PS7, Line 31:
nit: drop blank line
Done
https://review.coreboot.org/c/flashrom/+/62898/comment/c75ce3c6_3572948f PS7, Line 38:
nit: drop blank line
Done
https://review.coreboot.org/c/flashrom/+/62898/comment/beb574b3_18a6fa57 PS7, Line 69: uint##bits##_t name##bits (const uint##bits##_t value) { return value; }
nit: indent macro body for clarity: […]
Done
https://review.coreboot.org/c/flashrom/+/62898/comment/aea715da_4bae15c8 PS7, Line 79: uint##bits##_t name##bits (const uint##bits##_t value) { return swap##bits (value); }
Ditto
Done
File hwaccess_endian_big.c:
PS7:
Ah, I just saw that you plan on dropping these symbols. Then scratch this idea.
The __FLASHROM_X_ENDIAN__ should only stay as long as it is needed. For printing the buildinfo we should introduce a better mechanism, which passes all build info from the build system to the code.
-
Thomas Heijligen (Code Review)