Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.

View Change

6 comments:

• File hwaccess.h:

  • Patch Set #8, Line 77: uint##bits##_t name##bits (const uint##bits##_t value) { return swap##bits (value); }

    Exceeding 80 characters for better readability.

• File hwaccess.h:

  • Patch Set #7, Line 31:

    nit: drop blank line

    Done

  • Patch Set #7, Line 38:

    nit: drop blank line

    Done

  • Patch Set #7, Line 69: uint##bits##_t name##bits (const uint##bits##_t value) { return value; }

    nit: indent macro body for clarity: […]

    Done

  • Patch Set #7, Line 79: uint##bits##_t name##bits (const uint##bits##_t value) { return swap##bits (value); }

    Ditto

    Done

• File hwaccess_endian_big.c:

  • Patch Set #7:

    Ah, I just saw that you plan on dropping these symbols. Then scratch this idea.

    The __FLASHROM_X_ENDIAN__ should only stay as long as it is needed. For printing the buildinfo we should introduce a better mechanism, which passes all build info from the build system to the code.

To view, visit change 62898. To unsubscribe, or for help writing mail filters, visit settings.