Attention is currently required from: Nico Huber. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62282 )
Change subject: ichspi: Add Jasper Lake support ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
Are there any differences to EHL? If not, should we combine the two?
As far as I know, no, it's small core.
How do you propose your idea of combing looks like? I have a few more chipsets so perhaps that seems like a optimisation for a follow up WDYT?
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62282/comment/ed6ac280_f7caf1bb PS4, Line 1064: case CHIPSET_JASPER_LAKE:
Is this reachable?
I wasn't sure so I cased it to match with Elkhart not to be odd.
-
Edward O'Callaghan (Code Review)