Attention is currently required from: Nico Huber.
View Change
2 comments:
Patchset:
Patch Set #4:
Are there any differences to EHL? If not, should we combine the two?
As far as I know, no, it's small core.
How do you propose your idea of combing looks like? I have a few more chipsets so perhaps that seems like a optimisation for a follow up WDYT?
File ich_descriptors.c:
Patch Set #4, Line 1064: case CHIPSET_JASPER_LAKE:
Is this reachable?
I wasn't sure so I cased it to match with Elkhart not to be odd.
To view, visit change 62282. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib942d0b8942fe0a991b2af0b187414818485153d
Gerrit-Change-Number: 62282
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Sam McNally <sammc@google.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Thu, 24 Feb 2022 12:09:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment