Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66373 )
Change subject: tree: provide flashrom context into programmer's delay ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66373/comment/c0b875b4_742059aa PS4, Line 10: This is an important step to : remove the global state because it'll allow the programmer's data : to be used in delay functions. Maybe just drop part of this sentence after 'because' as its not what this patch does specifically following the advise Felix gave me earlier on another related patch.
https://review.coreboot.org/c/flashrom/+/66373/comment/4b284599_5a50c4d7 PS4, Line 13: : Programmers that use internal delay can provide NULL as a context. Move this up to the last paragraph.
https://review.coreboot.org/c/flashrom/+/66373/comment/d8b04c3f_7c80a654 PS4, Line 16: This is one of the steps on the way to move master's data : memory management behind the initialisation API, for more : context see other patches under the same topic specified below. Drop this paragraph.
-
Edward O'Callaghan (Code Review)