Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov.
View Change
3 comments:
Commit Message:
Patch Set #4, Line 10:
This is an important step to
remove the global state because it'll allow the programmer's data
to be used in delay functions.
Maybe just drop part of this sentence after 'because' as its not what this patch does specifically following the advise Felix gave me earlier on another related patch.
Patch Set #4, Line 13:
Programmers that use internal delay can provide NULL as a context.
Move this up to the last paragraph.
Patch Set #4, Line 16:
This is one of the steps on the way to move master's data
memory management behind the initialisation API, for more
context see other patches under the same topic specified below.
Drop this paragraph.
To view, visit change 66373. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229
Gerrit-Change-Number: 66373
Gerrit-PatchSet: 4
Gerrit-Owner: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Wed, 28 Sep 2022 02:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment