Change in flashrom[master]: raiden_debug_spi: Link spi_master struct to spi data - flashrom-gerrit

7 Oct 2021


      Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57972 )
Change subject: raiden_debug_spi: Link spi_master struct to spi data
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/57972/comment/70665b41_e9717435 
PS2, Line 1404: free(ctx_data);
              : 	free(spi_config);
...
spi_config is independent pointer and it won't disappear after free(ctx_data)?
That's it. Both pointers live on the stack.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/57972
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5400802aa6961538df12fcd5339f7e2a5db145a1
Gerrit-Change-Number: 57972
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Thu, 07 Oct 2021 10:48:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment