Change in flashrom[master]: Hide redondant 'Error: SCIP never cleared!' message

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40328 )

Change subject: Hide redondant 'Error: SCIP never cleared!' message
......................................................................

Hide redondant 'Error: SCIP never cleared!' message

This will hide redondant 'Error: SCIP never cleared!' messahe on ICH7.
https://paste.flashrom.org/view.php?id=3282

Note that this will take a very long time in comparison with v0.9.7-r1711 version.

current version gives:
time ./flashrom -p internal
flashrom v1.2-24-gf572b50-dirty on Linux 5.4.0-4-amd64 (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
Found chipset "Intel ICH7/ICH7R".
Enabling flash write... OK.
Found SST flash chip "SST49LF004A/B" (512 kB, FWH) mapped at physical address 0x00000000fff80000.
No operations were specified.

real	0m31,031s
user	0m10,079s
sys	0m20,785s

and old version v0.9.7-r171 will go faster:
time ./flashrom -p internal
flashrom v0.9.7-r1711 on Linux 5.4.0-4-amd64 (x86_64)
flashrom is free software, get the source code at http://www.flashrom.org

Calibrating delay loop... OK.
sh: 1: dmidecode: not found
dmidecode execution unsuccessful - continuing without DMI info
Found chipset "Intel ICH7/ICH7R". Enabling flash write... OK.
Found SST flash chip "SST49LF004A/B" (512 kB, FWH) at physical address 0xfff80000.
No operations were specified.

real	0m0,861s
user	0m0,844s
sys	0m0,008s

Change-Id: I0795653bd9ababccf666ed8af0c9bff22853371d
Signed-off-by: Elyes HAOUAS 
---
M ichspi.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/28/40328/1

diff --git a/ichspi.c b/ichspi.c
index 12ee126..19fc29e 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -852,7 +852,7 @@
    	programmer_delay(10);
    }
    if (!timeout) {
-		msg_perr("Error: SCIP never cleared!\n");
+		msg_pdbg("Error: SCIP never cleared!\n");
    	return 1;
    }

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40328 )

Change subject: Hide redondant 'Error: SCIP never cleared!' message
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40328 )

Change subject: Hide redondant 'Error: SCIP never cleared!' message
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/c/flashrom/+/40328/1/ichspi.c 
File ichspi.c:

https://review.coreboot.org/c/flashrom/+/40328/1/ichspi.c@850 
PS1, Line 850: 	timeout = 100 * 60;	/* 60 ms are 9.6 million cycles at 16 MHz. */
You're still hitting this timeout for every SPI flash chip, even if you don't see the message. Something should indicate that your hardware has the SPI controller in a non-working state, so the proper fix would be to mask the SPI capabilities in that case.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40328 )

Change subject: Hide redondant 'Error: SCIP never cleared!' message
......................................................................

Patch Set 1:

I think I found the problem...

https://github.com/flashrom/flashrom/commit/92d6a861ce0e4727c911fd8d6aeba312...

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40328 )

Change subject: Hide redondant 'Error: SCIP never cleared!' message
......................................................................

Patch Set 1:
> Patch Set 1:
>
> I think I found the problem...
>
> https://github.com/flashrom/flashrom/commit/92d6a861ce0e4727c911fd8d6aeba312...

Please, how to revert?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40328 )

Change subject: Hide redondant 'Error: SCIP never cleared!' message
......................................................................

Patch Set 1:
> Patch Set 1:
> > Patch Set 1:
> >
> > I think I found the problem...
> >
> > https://github.com/flashrom/flashrom/commit/92d6a861ce0e4727c911fd8d6aeba312...
>
> Please, how to revert?

CB:40401

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/40328 )

Change subject: Hide redondant 'Error: SCIP never cleared!' message
......................................................................

Abandoned

see https://review.coreboot.org/c/flashrom/+/40401